Remove Manhattan distances from trade routes #2094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CLASSIC trade route revenue style was using map_distance() which is the Manhattan distance. Using Euclidian makes much more sense since this is how units move. Closes longturn#882.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Manhattan distance is
|deltaX| + |deltaY|, which only makes sense when you can't move in diagonal. Since caravans can use the diagonal, the "Euclidian" (shortest path) distance is better suited for trade routes.This introduces an incompatibility by changing (lowering) trade revenue for rulesets currently using CLASSIC. Since trade routes are usually OP, I don't think this is a big deal.
Closes #882.